[BUGFIX] Create contentRecordRenderer via API #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the Implementing of the ContentRecordRenderer with API. T3-Version-Switch not necessary.
|
Thanks for PR, but CI is not happy,
|
|
This fix works for me. |
bmoex
reviewed
Aug 8, 2023
|
Resolves: #433 |
bmoex
approved these changes
Aug 8, 2023
ervaude
approved these changes
Aug 8, 2023
|
@achimfritz - please merge |
achimfritz
reviewed
Aug 8, 2023
| $contentRecordRenderer->setContentObjectRenderer($cObj); | ||
| $contentRecordRenderer->setRequest($this->getRequest()); | ||
| $contentRecordRenderer = $cObj->getContentObject('RECORDS'); | ||
| if ($contentRecordRenderer === null) { |
There was a problem hiding this comment.
@ervaude when can this occure? (cannot imaging?) i would prefer to remove this check, and the Exception?
There was a problem hiding this comment.
The check is only "useful" for phpstan because $cObj->getContentObject('RECORDS'); could return null.
But if the RECORDS cObject is not registered TYPO3 would not function at all.
When we remove the check we'll need a phpstan ignore-error entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the Implementing of the ContentRecordRenderer with API. T3-Version-Switch not necessary.