Remove transpiler + a few small improvements #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert to 'require'-based imports to avoid having to transpile. Also removes fs-promise in favor of just using `util.promisify`
KlaasH
changed the title
Removes babel transpilation and switches the claudia commands to point at the source directory. The config still gets built by its own script, but now goes back into src/config (.xml files in that directory are now .gitignored).
An unqualified tile URL will produce a somewhat unhelpful message if there's no default config file. This catches errors from opening the config file and sets a more helpful message in that situation.
KlaasH
force-pushed
the
feature/kjh/remove-transpiler
branch
from
0d123bc to
5a6c14f
Compare
This is a back-end project, so there's no reason not to log, and indeed it's very useful when debugging Lambda functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Applies some of the changes noted in #129 that were done in the https://github.com/azavea/pfb-network-connectivity and are worth bringing back into this version. Most notably, removing the transpilation step. Since Node still doesn't support ES6-style modules, this meant downgrading all the imports and utility modules to the CommonJS-style
require/module.exports =setup, but that seems like a reasonable price to pay for the reduced complexity.This also applies some small changes:
util/fs-promise.jshelper, using the built-inutil.promisifyinsteadclaudia-local-api--currently identical to @mattdelsordo's fork but there's a decent chance we'll need more tweaks, and it makes sense to have it in the fold anyway.Testing Instructions
scripts/updateandscripts/serverConnects #129.