Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3817 Full-width paragraphs may have wrong width when not in the Content region #3818

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

bberndt-uaz
Copy link
Contributor

@bberndt-uaz bberndt-uaz commented Oct 24, 2024

Description

This pull request makes the following changes:

  1. In az_paragraphs_full_width.css, reverts a couple changes to selectors made in Closes #3773 Styling issues with Box style Text on Media paragraphs #3774, so that some specific full-width background styling is applied only to the Content region. (The .region .az-full-width-row rule is the only exception.)
    • Note: I'm not sure if the styling from the .region-content .az-full-width-column-content rule is ever applied: other rules seem to override everything in that rule.
  2. To fix an issue with full-width Text with Background paragraphs not using the full width of the page, (a) apply the styling in az_paragraphs_az_text_background.css to all regions instead of just the Content region and (b) move some necessary full-width background styling from az_paragraphs_az_text_media.css to az_paragraphs_full_width.css.

Related issues

How to test

Probo review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3818.probo.build

Check existing demo pages along with the following:

  1. https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3818.probo.build/text-media-full-width-blocks
  2. https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3818.probo.build/text-media-standard-width-blocks
  3. https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3818.probo.build/text-media-all-blocks
  4. https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3818.probo.build/text-background-full-width-blocks
  5. https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3818.probo.build/text-background-standard-width-blocks
  6. https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3818.probo.build/text-background-all-blocks
  7. https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3818.probo.build/full-width-combo-test

Follow-up issue:

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@bberndt-uaz bberndt-uaz added bug Something isn't working high priority Must get done for this milestone labels Oct 24, 2024
@bberndt-uaz bberndt-uaz self-assigned this Oct 24, 2024
@bberndt-uaz bberndt-uaz added backport Changes to be back-ported to previous minor release branch patch release Issues to be included in the next patch release labels Oct 24, 2024
@bberndt-uaz bberndt-uaz marked this pull request as ready for review October 24, 2024 22:02
@bberndt-uaz bberndt-uaz requested a review from a team as a code owner October 24, 2024 22:02
@danahertzberg
Copy link
Contributor

danahertzberg commented Oct 25, 2024

Interesting the full-width background in a full-width region have a gap on the right side..

image

@bberndt-uaz bberndt-uaz requested a review from trackleft October 25, 2024 19:10
Copy link
Member

@trackleft trackleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool, full-width all the things.

@joeparsons joeparsons merged commit 3670635 into main Oct 25, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3817 branch October 25, 2024 20:53
This was referenced Nov 1, 2024
bberndt-uaz added a commit that referenced this pull request Nov 1, 2024
bberndt-uaz added a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Changes to be back-ported to previous minor release branch bug Something isn't working high priority Must get done for this milestone patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Full-width paragraphs may have wrong width when not in the Content region
5 participants