Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked version of pheromone/phpcs-security-audit with Composer 2.0 compatible patch applied. #4

Closed
wants to merge 2 commits into from

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Oct 27, 2020

The latest commit to this repo seems to have broken all Quickstart builds due to this issue: FloeDesignTechnologies/phpcs-security-audit#82

I've created a fork of that repo in our az-digital namespace with the changes from that PR applied to master here:
https://github.com/az-digital/phpcs-security-audit

This PR changes our dev metapacakge to reference our fork for now.

@joeparsons
Copy link
Member Author

It'd be good to merge this ASAP even if we eventually decide to remove pheremone/phpcs-security-audit altogether.

@joeparsons
Copy link
Member Author

Actually, this probably won't work as-is. I think only repositories defined in the top-level/outermost composer.json are used (in the scaffolding repo) 😞 .

Copy link

@tadean tadean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to specify az-digital/phpcs-security-audit since the forked version has the name changed?

@trackleft
Copy link
Member

Does this need to specify az-digital/phpcs-security-audit since the forked version has the name changed?

I changed it back

@joeparsons
Copy link
Member Author

Does this need to specify az-digital/phpcs-security-audit since the forked version has the name changed?

@tadean I don't think so unless we also want to modify the name of the package specified in the composer.json file in our fork.

@tadean
Copy link

tadean commented Oct 27, 2020

Does this need to specify az-digital/phpcs-security-audit since the forked version has the name changed?

@tadean I don't think so unless we also want to modify the name of the package specified in the composer.json file in our fork.

My bad, at the time I looked it had been changed: az-digital/phpcs-security-audit@aaad914

@trackleft trackleft closed this Oct 27, 2020
@joeparsons joeparsons deleted the feature/349 branch December 3, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants