Sqlite and MySql support for asynk #141

pxp9 · 2023-08-26T20:41:18Z

PostgreSQL reimplementation in sqlx
SQLite implementation in sqlx
MySQL implementation in sqlx
Organize the features
Delete tokio_postgres and bb8 deps from crate.
Add new testing DBs setups to workflow (Added only for Sqlite and Postgresql).
Add new testing for MySQL
Add testing for blocking and fang_derive_error

…s and also probably need to make queries folder for `sqlite` and `mysql`

pxp9 · 2023-08-28T19:53:38Z

There is one bug in sqlite implementation or test.

For some reason

asynk::async_queue::sqlite::fetch_and_touch_test fails because it does not fetch nothing because SQLite has locked the entry.

when this FOR UPDATE SKIP LOCKED is deleted it from SQLite fetch_task_type query, works fine.

ayrat555

looking good. a couple of comment

fang/postgres_migrations/migrations/2022-08-20-151615_create_fang_tasks/up.sql

fang/src/asynk/async_queue.rs

fang/src/asynk/async_runnable.rs

fang/Cargo.toml

fang/src/asynk/async_queue.rs

ayrat555

looking really good,

.github/workflows/rust.yml

fang/Cargo.toml

fang/postgres_migrations/migrations/2022-08-20-151615_create_fang_tasks/up.sql

fang/src/asynk/backend_sqlx.rs

This commit adds the `Makefile` improvements changes

pxp9 · 2024-04-15T17:46:39Z

Sometimes fetch and touch in mysql fetches the task that is created after that one that should fetch

pxp9 · 2024-04-16T08:13:21Z

Sometimes fetch and touch in mysql fetches the task that is created after that one that should fetch

this test has 3 different situations:

It passes
It fails with unwrap because it did not fetch any task
it fails with assert because it got the wrong task (should get always the older task first).

changes since this requested changes

changes since last review

ayrat555

looking good. a couple of comments

fang/README.md

fang/mysql_migrations/migrations/2023-08-17-102017_create_fang_tasks/up.sql

ayrat555

changes should be added to the changelog file

fang/README.md

Dopplerian

Seeing a ton of muts be deleted is one of the most satisfying things in this world.

0xCAB0

LGTM distinguished gentlemen

possible impl with sqlx, we need to refactor dependencies and feature…

2eb4b48

…s and also probably need to make queries folder for `sqlite` and `mysql`

pxp9 marked this pull request as draft August 26, 2023 20:41

pxp9 requested review from Dopplerian and ayrat555 August 26, 2023 20:41

pxp9 added 2 commits August 26, 2023 22:43

fix clippy xd

1a09371

finally sqlite almost work, need help to debug something

cbe2d99

pxp9 and others added 11 commits August 28, 2023 22:02

deleting some expects

63b39c3

sqlite may work in workflow

fb7d4ba

stupid workflow work

2ff47e1

plz work

fdbe924

plz work , think i have fixed

20f376a

fix workflow , now will work :D

e79c0ee

this should work

7e1ac88

this will definitely work

4f308f2

clean up so it works incorrectly faster

204a38a

okay that didn't work so idk what i'm doing here

fdb4f1e

if this works i'm dropping out of university

5ba9910

ayrat555 reviewed Aug 29, 2023

View reviewed changes

fang/postgres_migrations/migrations/2022-08-20-151615_create_fang_tasks/up.sql Outdated Show resolved Hide resolved

fang/src/asynk/async_queue.rs Outdated Show resolved Hide resolved

fang/src/asynk/async_runnable.rs Outdated Show resolved Hide resolved

pxp9 added 5 commits August 29, 2023 23:14

store uuid as text , so this way PostgreSQL schema will not change

5119dcf

fix comment

168b476

fix clippy

f4459d9

implement backend sqlx trait that allows better code

bf53cfa

better implementation with enum variants

0040820

pxp9 requested a review from ayrat555 August 30, 2023 07:05

Dopplerian reviewed Aug 30, 2023

View reviewed changes

fang/Cargo.toml Outdated Show resolved Hide resolved

fang/src/asynk/async_queue.rs Outdated Show resolved Hide resolved

ayrat555 reviewed Aug 30, 2023

View reviewed changes

.github/workflows/rust.yml Show resolved Hide resolved

fang/Cargo.toml Outdated Show resolved Hide resolved

fang/postgres_migrations/migrations/2022-08-20-151615_create_fang_tasks/up.sql Outdated Show resolved Hide resolved

fang/src/asynk/backend_sqlx.rs Outdated Show resolved Hide resolved

Dopplerian added 3 commits August 31, 2023 11:46

Merge branch 'master' into support-sqlite-mysql-asynk

d6eb6e5

This commit adds the `Makefile` improvements changes

Makefile now creates tests_sqlite directory

08238bc

make asynk tests use .env variables

169d955

pxp9 added 4 commits April 15, 2024 16:30

use variant NoBackend instead Option

edf744a

fix clippy

f0ae9fe

delete dummy variant

ce47e61

changing sqlite and mysql migrations

baef61e

pxp9 added 7 commits April 16, 2024 10:54

sqlx uuid encoding and decoding for sqlite and postgres

527868b

delete uuid previous impl comment

0f0be07

fix retry_task impl

c611d60

fix mysql timestamp precision

45d896a

rework encoding Datime<Utc> for postgresql and sqlite

ea85604

rework encoding Uuid for mysql

94fd332

fix clippy

9da8548

pxp9 requested a review from Dopplerian April 17, 2024 11:14

ayrat555 reviewed Apr 17, 2024

View reviewed changes

fang/README.md Outdated Show resolved Hide resolved

fang/README.md Outdated Show resolved Hide resolved

fang/mysql_migrations/migrations/2023-08-17-102017_create_fang_tasks/up.sql Outdated Show resolved Hide resolved

pxp9 added 2 commits April 17, 2024 20:17

fix serde_json::Value decoding and encoding

aafb352

README stuff

e7c15bb

pxp9 requested a review from ayrat555 April 17, 2024 18:23

ayrat555 approved these changes Apr 17, 2024

View reviewed changes

fang/README.md Show resolved Hide resolved

Dopplerian approved these changes Apr 17, 2024

View reviewed changes

pxp9 added 2 commits April 18, 2024 11:46

improving API

af8e0b4

improving worker API

adff5b2

pxp9 requested review from ayrat555 and Dopplerian April 18, 2024 10:04

Dopplerian approved these changes Apr 18, 2024

View reviewed changes

0xCAB0 approved these changes Apr 19, 2024

View reviewed changes

pxp9 merged commit bcbb48d into master Apr 19, 2024
8 checks passed

pxp9 deleted the support-sqlite-mysql-asynk branch April 19, 2024 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sqlite and MySql support for asynk #141

Sqlite and MySql support for asynk #141

pxp9 commented Aug 26, 2023 •

edited by 0xCAB0

Loading

pxp9 commented Aug 28, 2023

ayrat555 left a comment

ayrat555 left a comment

pxp9 commented Apr 15, 2024 •

edited

Loading

pxp9 commented Apr 16, 2024 •

edited

Loading

ayrat555 left a comment

ayrat555 left a comment

Dopplerian left a comment

0xCAB0 left a comment

Sqlite and MySql support for asynk #141

Sqlite and MySql support for asynk #141

Conversation

pxp9 commented Aug 26, 2023 • edited by 0xCAB0 Loading

pxp9 commented Aug 28, 2023

ayrat555 left a comment

Choose a reason for hiding this comment

ayrat555 left a comment

Choose a reason for hiding this comment

pxp9 commented Apr 15, 2024 • edited Loading

pxp9 commented Apr 16, 2024 • edited Loading

ayrat555 left a comment

Choose a reason for hiding this comment

ayrat555 left a comment

Choose a reason for hiding this comment

Dopplerian left a comment

Choose a reason for hiding this comment

0xCAB0 left a comment

Choose a reason for hiding this comment

pxp9 commented Aug 26, 2023 •

edited by 0xCAB0

Loading

pxp9 commented Apr 15, 2024 •

edited

Loading

pxp9 commented Apr 16, 2024 •

edited

Loading