Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs that are not compatible with pydantic2.x #191

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

0x587
Copy link

@0x587 0x587 commented Aug 17, 2023

I solved the problem that fastapi-crudrouter is not compatible with pydantic2.x, related issue #189, #190
The changes only involve fastapi_crudrouter/core/_utils.py

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fastapi-crudrouter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 0:10am

@cloudyyoung
Copy link

Hey I was wandering around for this issue/pr and I appreciate your work!
To add on, another line here would be schema.__fields__[pk_field].annotation for pydantic 2.x.

@0x587
Copy link
Author

0x587 commented Sep 13, 2023

Hey I was wandering around for this issue/pr and I appreciate your work! To add on, another line here would be schema.__fields__[pk_field].annotation for pydantic 2.x.

Thank you for your generous advice.
Then I got some useful information from https://docs.pydantic.dev/2.3/migration/#changes-to-pydanticbasemodel which suggested me to use model_fields instead of __fields__. I will append these changes to my PR later.

marcelomendoncasoares

This comment was marked as resolved.

@marcelomendoncasoares
Copy link

Hi, everyone! Very interested in this release, as this library will really accelerate the development of a project I have just started. Reading the history, is something still missing to approve? I'd be glad to help.

@lohxx
Copy link

lohxx commented Oct 24, 2023

Is there any estimate for when this PR will be merged?

@0x587
Copy link
Author

0x587 commented Oct 24, 2023

I just added the missing import, and I'm really looking forward to seeing this PR merged.
Thank help from @anthonypelletier

@0x587
Copy link
Author

0x587 commented Nov 1, 2023

Okay, I have modified the location of the import. @awtkns

@jofhanen
Copy link

This is still an issue, will this patch be updated soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants