Skip to content

Commit

Permalink
chore: update screen preset event name (#5)
Browse files Browse the repository at this point in the history
  • Loading branch information
jingnanl committed Jun 11, 2024
1 parent 89c6201 commit 24fd914
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 19 deletions.
10 changes: 3 additions & 7 deletions src/provider/ClickstreamProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -395,15 +395,11 @@ export class ClickstreamProvider {

const pages = getCurrentPages();
const currentPage = pages.length > 0 ? pages[pages.length - 1] : null;
const previousPage = pages.length > 1 ? pages[pages.length - 2] : null;
const screenAttributes: ClickstreamAttributes = {
[ReservedAttribute.SCREEN_ID]: currentPage ? currentPage.getPageId() : '',
[ReservedAttribute.SCREEN_ROUTE]: this.getPageRoute(currentPage),
[ReservedAttribute.PREVIOUS_SCREEN_ID]: previousPage
? previousPage.getPageId()
[ReservedAttribute.SCREEN_UNIQUE_ID]: currentPage
? currentPage.getPageId()
: '',
[ReservedAttribute.PREVIOUS_SCREEN_ROUTE]:
this.getPageRoute(previousPage),
[ReservedAttribute.SCREEN_ID]: this.getPageRoute(currentPage),
};

return {
Expand Down
4 changes: 2 additions & 2 deletions src/provider/Event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ export const ReservedAttribute = {
SESSION_NUMBER: '_session_number',

// Page
SCREEN_UNIQUE_ID: '_screen_unique_id',
SCREEN_ID: '_screen_id',
SCREEN_ROUTE: '_screen_route',
SCREEN_NAME: '_screen_name',
PREVIOUS_SCREEN_UNIQUE_ID: '_previous_screen_unique_id',
PREVIOUS_SCREEN_ID: '_previous_screen_id',
PREVIOUS_SCREEN_ROUTE: '_previous_screen_route',
PREVIOUS_SCREEN_NAME: '_previous_screen_name',

// Other
Expand Down
6 changes: 3 additions & 3 deletions src/tracker/AppTracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ export class AppTracker extends BaseTracker {
this.provider.eventRecorder.sendEvent({
name: PresetEvent.USER_ENGAGEMENT,
attributes: {
[ReservedAttribute.SCREEN_ID]: lastPage.id,
[ReservedAttribute.SCREEN_ROUTE]: lastPage.route,
[ReservedAttribute.SCREEN_UNIQUE_ID]: lastPage.id,
[ReservedAttribute.SCREEN_ID]: lastPage.route,
[ReservedAttribute.SCREEN_NAME]: lastPage.name,
[ReservedAttribute.ENGAGEMENT_TIMESTAMP]:
new Date().getTime() - lastPage.timestamp,
[ReservedAttribute.PREVIOUS_SCREEN_UNIQUE_ID]: undefined,
[ReservedAttribute.PREVIOUS_SCREEN_ID]: undefined,
[ReservedAttribute.PREVIOUS_SCREEN_ROUTE]: undefined,
[ReservedAttribute.PREVIOUS_SCREEN_NAME]: undefined,
},
});
Expand Down
14 changes: 7 additions & 7 deletions src/tracker/PageTracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,11 @@ export class PageTracker extends BaseTracker {
this.provider.eventRecorder.sendEvent({
name: PresetEvent.SCREEN_VIEW,
attributes: {
[ReservedAttribute.SCREEN_ID]: pageId,
[ReservedAttribute.SCREEN_ROUTE]: pageRoute,
[ReservedAttribute.SCREEN_UNIQUE_ID]: pageId,
[ReservedAttribute.SCREEN_ID]: pageRoute,
[ReservedAttribute.SCREEN_NAME]: pageTitle,
[ReservedAttribute.PREVIOUS_SCREEN_ID]: lastPage.id,
[ReservedAttribute.PREVIOUS_SCREEN_ROUTE]: lastPage.route,
[ReservedAttribute.PREVIOUS_SCREEN_UNIQUE_ID]: lastPage.id,
[ReservedAttribute.PREVIOUS_SCREEN_ID]: lastPage.route,
[ReservedAttribute.PREVIOUS_SCREEN_NAME]: lastPage.name,
[ReservedAttribute.ENGAGEMENT_TIMESTAMP]:
lastPage.timestamp > 0
Expand All @@ -134,13 +134,13 @@ export class PageTracker extends BaseTracker {
this.provider.eventRecorder.sendEvent({
name: PresetEvent.USER_ENGAGEMENT,
attributes: {
[ReservedAttribute.SCREEN_ID]: lastPage.id,
[ReservedAttribute.SCREEN_ROUTE]: lastPage.route,
[ReservedAttribute.SCREEN_UNIQUE_ID]: lastPage.id,
[ReservedAttribute.SCREEN_ID]: lastPage.route,
[ReservedAttribute.SCREEN_NAME]: lastPage.name,
[ReservedAttribute.ENGAGEMENT_TIMESTAMP]:
new Date().getTime() - lastPage.timestamp,
[ReservedAttribute.PREVIOUS_SCREEN_UNIQUE_ID]: undefined,
[ReservedAttribute.PREVIOUS_SCREEN_ID]: undefined,
[ReservedAttribute.PREVIOUS_SCREEN_ROUTE]: undefined,
[ReservedAttribute.PREVIOUS_SCREEN_NAME]: undefined,
},
});
Expand Down

0 comments on commit 24fd914

Please sign in to comment.