Allow build on arm64 #3
Conversation
* replace all `amd64` and `x86_64` references with $TARGETARCH (or computed values based off that) * re-enable certificate checking * unquiet wget invocations to allow debugging * unify download call usage
.devcontainer/Dockerfile
Outdated
| ARG TERRAFORM_VERSION=1.3.6 | ||
| RUN mkdir -p /tmp/download \ | ||
| && cd /tmp/download \ | ||
| && wget -O terraform.zip "https://releases.hashicorp.com/terraform/1.3.6/terraform_1.3.6_linux_${TARGETARCH}.zip" \ |
There was a problem hiding this comment.
Hi @DavidS-om , thank you for your PR.
The TERRAFORM_VERSION is not being used here. Would be great to allow the user to pass it on as arguments.
| @@ -7,6 +7,8 @@ | |||
| ARG VARIANT="jammy" | |||
| FROM mcr.microsoft.com/vscode/devcontainers/base:0-${VARIANT} | |||
|
|
|||
| ARG TARGETARCH | |||
There was a problem hiding this comment.
If the user doesn't provide a value, how the build would respond?
There was a problem hiding this comment.
This is set automatically by buildkit. I've added a comment to point this out
|
|
||
| # AWS CLI | ||
| SHELL ["/bin/zsh", "-c"] | ||
| RUN mkdir -p /tmp/download \ | ||
| && cd /tmp/download \ | ||
| && curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" --silent -o "awscliv2.zip" \ | ||
| && ARCH=${TARGETARCH/amd64/x86_64} \ |
There was a problem hiding this comment.
Why provide ARCH twice here?
There was a problem hiding this comment.
because of the awscli hosting URLs, this needs to replace amd64 => x86_64 and arm64 => aarch64. Since I didn't want to touch the TARGETARCH, this code is overwriting ARCH a second time to apply both replaces.
|
Thanks for your feedback! All good points. I hope I can provide an update early next week. |
|
Looks like I need to re-do the work on top of #6 to address the merge conflict |
馃 Pull Request
Changes
amd64andx86_64references with $TARGETARCH (or computed values based off that)Type of change
Why
Fixes #2