Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate the configured region to the S3 client #600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: propagate the configured region to the S3 client #600

wants to merge 1 commit into from

Conversation

sielenk-yara
Copy link

This is a fix for issue #599.

markjschreiber
markjschreiber requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however I think a unit test should be added to assert that the region is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markjschreiber markjschreiber markjschreiber requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sielenk-yara @markjschreiber