Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed the configuration from the filesystem provider and used the one in the filesystem instead. #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sielenk-yara
Copy link

@sielenk-yara sielenk-yara commented Jan 16, 2025

This is a fix for issue #597.

*
* @param configuration The new configuration containing the timeout info
*/
public void setConfiguration(S3NioSpiConfiguration configuration) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing a public method is a breaking change to the API. If possible it should be reimplemented or alternatively deprecate the method and update the docs with a recommendation on a better alternative.

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some things to change:

  1. The public method should be deprecated rather than removed (a breaking change).
  2. Add unit tests to demonstrate that the configuration has been set to prevent regressions in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants