bug(nix:corretto): use autoPatchelfHook on all systems and ignore als… #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a lib requirements everywhere.
camshaft
approved these changes
May 16, 2024
toidiu
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4560
Description of changes:
Revert my previous naive approach to getting Corretto installed on arm and instead tell autoPatchelf to ignore the sound library dependency.
Call-outs:
This only affects arm, which isn't running tests using Corretto in CI, yet.
An ad-hoc example of the happy_path test on arm is here and while it should fail due to no retries, you can see a few java providers passing in the first few screens of test output.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.