feat: Allow instance store policy to be configured on BR family #7044

jonathan-innis · 2024-09-20T08:22:40Z

Fixes #N/A

Description

This change adds support for RAID0-ing the instance store volumes on BR

This change also introduces a launchtemplate_counter tool to assess the impact of this change on the number of launch templates that can be generated.

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-09-20T08:22:59Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`254cb63`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f4f0c2d00e4f00084385e7

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-20T08:59:37Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-57a679752aa74b57c52dea58d44079453e271ea9.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-57a679752aa74b57c52dea58d44079453e271ea9" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

/karpenter snapshot

coveralls · 2024-09-20T09:05:59Z

Pull Request Test Coverage Report for Build 11046137589

Details

22 of 22 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 83.398%

Totals
Change from base Build 11042306971:	0.3%
Covered Lines:	5561
Relevant Lines:	6668

💛 - Coveralls

github-actions · 2024-09-20T09:06:40Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-b370c3fdad64e15b9fb835e7c7edb890edcdbb1b.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-b370c3fdad64e15b9fb835e7c7edb890edcdbb1b" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-21T23:39:27Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-413abfe40558b4efb3bb0aaad1f3010a7a6f4833.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-413abfe40558b4efb3bb0aaad1f3010a7a6f4833" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-22T23:23:30Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-72c445433f539f6767ea993c7f28fdca27e155df.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-72c445433f539f6767ea993c7f28fdca27e155df" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

website/content/en/preview/reference/metrics.md

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-23T22:20:25Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-3be6e711daffb8f3b906492b012fab8780267f69.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-3be6e711daffb8f3b906492b012fab8780267f69" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/providers/amifamily/bootstrap/bottlerocket.go

pkg/providers/amifamily/bootstrap/bottlerocketsettings.go

pkg/providers/amifamily/ubuntu.go

pkg/providers/instancetype/types.go

test/suites/scheduling/suite_test.go

pkg/providers/launchtemplate/suite_test.go

jonathan-innis

/karpenter snapshot

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-26T02:09:45Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-b81f78bb2efd328c43eca83288ca40af87c72372.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-b81f78bb2efd328c43eca83288ca40af87c72372" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

github-actions · 2024-09-26T02:11:38Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-a2e0f6b840d1c7b183c14b1fdaf9dffd4faef450.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-a2e0f6b840d1c7b183c14b1fdaf9dffd4faef450" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis force-pushed the add-br-instance-store-support branch 3 times, most recently from 699c069 to 57a6797 Compare September 20, 2024 08:46

jonathan-innis commented Sep 20, 2024

View reviewed changes

jonathan-innis force-pushed the add-br-instance-store-support branch from 57a6797 to b370c3f Compare September 20, 2024 09:01

jonathan-innis commented Sep 20, 2024

View reviewed changes

jonathan-innis force-pushed the add-br-instance-store-support branch 3 times, most recently from 2e2d3ef to 413abfe Compare September 21, 2024 23:29

jonathan-innis commented Sep 21, 2024

View reviewed changes

jonathan-innis force-pushed the add-br-instance-store-support branch from 35c6092 to 72c4454 Compare September 22, 2024 23:18

jonathan-innis marked this pull request as ready for review September 22, 2024 23:19

jonathan-innis requested a review from a team as a code owner September 22, 2024 23:19

jonathan-innis requested a review from tzneal September 22, 2024 23:19

jonathan-innis commented Sep 22, 2024

View reviewed changes

jonathan-innis enabled auto-merge (squash) September 23, 2024 05:49

rschalo reviewed Sep 23, 2024

View reviewed changes

website/content/en/preview/reference/metrics.md Show resolved Hide resolved

jonathan-innis force-pushed the add-br-instance-store-support branch from 8d0f861 to 3be6e71 Compare September 23, 2024 22:13

jonathan-innis commented Sep 23, 2024

View reviewed changes

rschalo reviewed Sep 24, 2024

View reviewed changes

pkg/providers/amifamily/bootstrap/bottlerocket.go Outdated Show resolved Hide resolved

rschalo reviewed Sep 24, 2024

View reviewed changes

pkg/providers/amifamily/bootstrap/bottlerocketsettings.go Show resolved Hide resolved

rschalo reviewed Sep 24, 2024

View reviewed changes

pkg/providers/amifamily/ubuntu.go Outdated Show resolved Hide resolved

jmdeal reviewed Sep 24, 2024

View reviewed changes

pkg/providers/instancetype/types.go Outdated Show resolved Hide resolved

test/suites/scheduling/suite_test.go Outdated Show resolved Hide resolved

pkg/providers/launchtemplate/suite_test.go Outdated Show resolved Hide resolved

jonathan-innis force-pushed the add-br-instance-store-support branch from 4ae45b5 to ae3ee37 Compare September 25, 2024 00:29

jonathan-innis marked this pull request as draft September 25, 2024 02:49

auto-merge was automatically disabled September 25, 2024 02:49
Pull request was converted to draft

jonathan-innis added 5 commits September 25, 2024 18:32

Allow instance store policy to be configured on BR family

917442e

Update auto-gen docs

9c48a7f

Add launch template counter tool

2447600

Drop sizing down the data volume when instance store is used

855a0d2

PR comments

8dc4c1f

jonathan-innis force-pushed the add-br-instance-store-support branch 5 times, most recently from 28aed2f to 93e20f6 Compare September 26, 2024 01:55

jonathan-innis marked this pull request as ready for review September 26, 2024 02:02

jonathan-innis force-pushed the add-br-instance-store-support branch 2 times, most recently from 555ba85 to b81f78b Compare September 26, 2024 02:04

jonathan-innis commented Sep 26, 2024

View reviewed changes

jonathan-innis force-pushed the add-br-instance-store-support branch from b81f78b to a2e0f6b Compare September 26, 2024 02:06

jonathan-innis commented Sep 26, 2024

View reviewed changes

Add upgrade note

254cb63

jonathan-innis force-pushed the add-br-instance-store-support branch from a2e0f6b to 254cb63 Compare September 26, 2024 05:27

jonathan-innis enabled auto-merge (squash) September 26, 2024 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Allow instance store policy to be configured on BR family #7044

feat: Allow instance store policy to be configured on BR family #7044

jonathan-innis commented Sep 20, 2024 •

edited

Loading

netlify bot commented Sep 20, 2024 •

edited

Loading

jonathan-innis left a comment

github-actions bot commented Sep 20, 2024

jonathan-innis left a comment

coveralls commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024

jonathan-innis left a comment

github-actions bot commented Sep 21, 2024

jonathan-innis left a comment

github-actions bot commented Sep 22, 2024

jonathan-innis left a comment

github-actions bot commented Sep 23, 2024

jonathan-innis left a comment

jonathan-innis left a comment

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

feat: Allow instance store policy to be configured on BR family #7044

Are you sure you want to change the base?

feat: Allow instance store policy to be configured on BR family #7044

Conversation

jonathan-innis commented Sep 20, 2024 • edited Loading

netlify bot commented Sep 20, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

coveralls commented Sep 20, 2024 • edited Loading

Pull Request Test Coverage Report for Build 11046137589

Details

💛 - Coveralls

github-actions bot commented Sep 20, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 21, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 22, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 23, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

jonathan-innis commented Sep 20, 2024 •

edited

Loading

netlify bot commented Sep 20, 2024 •

edited

Loading

coveralls commented Sep 20, 2024 •

edited

Loading