Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting service annotations via helm chart #6894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesduffy
Copy link

@jamesduffy jamesduffy commented Aug 28, 2024

Fixes #N/A

Description
Allows setting annotations on the karpenter service. We need this so that we can add annotations to setup datadog to monitor karpenter. There are probably other use cases.

How was this change tested?

Generated a helm chart locally with the additional values:

service:
  annotations:
    ad.datadoghq.com/service.checks: |
      {
        "karpenter": {
          "cluster_check": true,
          "init_config": {},
          "instances": [
            {
              "openmetrics_endpoint": "http://%%host%%:8000/metrics",
              "exclude_metrics": [
                "^karpenter\\.go\\..*$"
              ]
            }
          ]
        }
      }

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jamesduffy jamesduffy requested a review from a team as a code owner August 28, 2024 21:45
@jamesduffy jamesduffy requested a review from jmdeal August 28, 2024 21:45
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 76f9570
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66cf9a6e4357d8000848af2d

@jmdeal
Copy link
Contributor

jmdeal commented Sep 5, 2024

What's preventing you from using the existing additionalAnnotations field? Unless absolutely necessary, we'd like to avoid additional configuration in the helm chart.

@jamesduffy
Copy link
Author

What's preventing you from using the existing additionalAnnotations field? Unless absolutely necessary, we'd like to avoid additional configuration in the helm chart.

additionalAnnotations adds the annotations to a lot of different things. This would be picked up from the Datadog agent as separate checks and instead of running just one check for Karpenter it would run duplicate checks for each place additionalAnnotations is injected. Therefore, we would need a way to add the annotation in a single place. Datadog annotations are often on the service.

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jamesduffy
Copy link
Author

@jmdeal I would like to move forward with this if my explanation makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants