Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document steps to expose metrics for EKS-A components #7970

Merged
merged 2 commits into from May 17, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Apr 11, 2024

Issue #, if available:
#7875
#4299
#4405

Description of changes:

  • Added documentation on exposing metrics for EKS-A components by configuring a proxy as a Daemonset on the host network. New section is added in observability within cluster management in the EKS-A docs.
  • Added design doc for exposing metrics of all EKS-components securely

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.40%. Comparing base (4fe9876) to head (e36f84e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7970   +/-   ##
=======================================
  Coverage   73.40%   73.40%           
=======================================
  Files         577      577           
  Lines       35900    35900           
=======================================
  Hits        26352    26352           
  Misses       7882     7882           
  Partials     1666     1666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
@jiayiwang7
Copy link
Member

/lgtm

Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A lot of my comments were just that we spell out "EKS Anywhere" and "Kubernetes" in public docs.

designs/expose-metrics.md Outdated Show resolved Hide resolved
designs/expose-metrics.md Outdated Show resolved Hide resolved
designs/expose-metrics.md Outdated Show resolved Hide resolved
designs/expose-metrics.md Outdated Show resolved Hide resolved
designs/expose-metrics.md Outdated Show resolved Hide resolved
designs/expose-metrics.md Outdated Show resolved Hide resolved
docs/content/en/docs/clustermgmt/observability/overview.md Outdated Show resolved Hide resolved
@jiayiwang7
Copy link
Member

/lgtm

@sp1999
Copy link
Member Author

sp1999 commented May 17, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit ce336c3 into aws:main May 17, 2024
8 checks passed
@sp1999 sp1999 deleted the docs-expose-metrics branch May 17, 2024 17:26
@sp1999
Copy link
Member Author

sp1999 commented May 17, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8167

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member Author

sp1999 commented May 17, 2024

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8168

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants