Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly parsing the TGT file causing the token to expire. #85

Open
wants to merge 3 commits into
base: mainline
Choose a base branch
from

Conversation

fordth
Copy link
Contributor

@fordth fordth commented Nov 30, 2023

This address issue#: 67

This change corrects the regex expression that incorrectly parsed the TGT file and therefore the token would expire.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jamolina
Copy link
Contributor

Thank you for your contribution @fordth . We'll review it and let you know if we have any questions

auth/kerberos/src/krb.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@smhmhmd smhmhmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can add the comment for the regex that would be great.
Other than that, I am good with the PR.
Thanks for the contribution.

@saikiranakula-amzn
Copy link
Collaborator

please also resolve merge conflicts

@smhmhmd
Copy link
Contributor

smhmhmd commented Dec 5, 2023

@fordth We have new logic for regex, could you please resolve the merge conflicts for the Dockerfiles

@smhmhmd
Copy link
Contributor

smhmhmd commented Dec 7, 2023

@fordth , Could you please rebase your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants