fix(amazonq): Add code reference opt-in config to non-SSO requests #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies files in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
erikayao93
changed the title
|
This pull request modifies a feature or fixes a bug, but it does not include a changelog entry. All pull requests that introduce new features or bug fixes must have a corresponding changelog item describing the changes. |
mr-lee
approved these changes
Sep 5, 2024
| export async function buildGenerateRecommendationRequest(editor: vscode.TextEditor): Promise<{ | ||
| export async function buildGenerateRecommendationRequest( | ||
| editor: vscode.TextEditor, | ||
| allowCodeWithReference: boolean |
There was a problem hiding this comment.
nit - align it with the API definition - allowRecommendationsWithReferences?
There was a problem hiding this comment.
I based it off of the same parameter in buildListRecommendationRequest here
nkomonen-amazon
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Without an SSO connection, code suggestions may still have references even if they have opted out in their settings.
Solution
When generating a recommendation request, always provide the
isSuggestionsWithCodeReferencesEnabledflag from configuration. This will default tofalseif the config is not found.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.