refactor(deps): remove unnecessary code (#5707)

We dont need this code anymore ---  License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: nkomonen-amazon <[email protected]>
aws · Oct 2, 2024 · 1e462f9 · 1e462f9
1 parent f27ddbe
commit 1e462f9
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 339 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -502,8 +502,6 @@
         "mime-types": "^2.1.32",
         "node-fetch": "^2.7.0",
         "portfinder": "^1.0.32",
-        "proper-lockfile": "^4.1.2",
-        "ps-list": "^8.1.1",
         "semver": "^7.5.4",
         "stream-buffers": "^3.0.2",
         "strip-ansi": "^5.2.0",

diff --git a/packages/core/src/shared/fs/node/fs.ts b/packages/core/src/shared/fs/node/fs.ts
diff --git a/packages/core/src/shared/utilities/processUtils.ts b/packages/core/src/shared/utilities/processUtils.ts
@@ -7,7 +7,6 @@ import * as proc from 'child_process'
 import * as crossSpawn from 'cross-spawn'
 import * as logger from '../logger'
 import { Timeout, CancellationError, waitUntil } from './timeoutUtils'
-import { isWeb } from '../extensionGlobals'
 
 export interface RunParameterContext {
     /** Reports an error parsed from the stdin/stdout streams. */
@@ -369,17 +368,3 @@ export class ChildProcess {
         return `${pid} [${this.#command} ${noparams ? '...' : this.#args.join(' ')}]`
     }
 }
-
-/**
- * Returns a sorted list of all PIDs currently running
- */
-export async function getPids(): Promise<number[]> {
-    if (isWeb()) {
-        throw new Error('getPids() is not supported in web mode')
-    }
-    // Note: This is an ESM module, which is why we cannot import it the standard way
-    // Note: This module is explicitly excluded in the web mode webpack since this breaks the bundling.
-    const psList = (await import('ps-list')).default
-    const pids = (await psList()).map((p) => p.pid)
-    return pids.sort((a, b) => a - b)
-}
diff --git a/packages/core/src/shared/utilities/searchUtils.ts b/packages/core/src/shared/utilities/searchUtils.ts
diff --git a/packages/core/src/test/shared/fs/node/fs.test.ts b/packages/core/src/test/shared/fs/node/fs.test.ts
diff --git a/packages/core/src/test/shared/utilities/processUtils.test.ts b/packages/core/src/test/shared/utilities/processUtils.test.ts
@@ -9,7 +9,7 @@ import { fs as fs2 } from '../../../shared'
 import * as os from 'os'
 import * as path from 'path'
 import { makeTemporaryToolkitFolder, tryRemoveFolder } from '../../../shared/filesystemUtilities'
-import { ChildProcess, eof, getPids } from '../../../shared/utilities/processUtils'
+import { ChildProcess, eof } from '../../../shared/utilities/processUtils'
 import { sleep } from '../../../shared/utilities/timeoutUtils'
 import { Timeout, waitUntil } from '../../../shared/utilities/timeoutUtils'
 
@@ -348,16 +348,3 @@ describe('ChildProcess', async function () {
         await writeShellFile(filename, file)
     }
 })
-
-describe('getPids', function () {
-    it('returns pids sorted in ascending order', async function () {
-        const pids = await getPids()
-        assert.ok(pids.length > 0)
-        assert.deepStrictEqual(
-            pids.some((pid) => typeof pid !== 'number'),
-            false
-        )
-        const sortedPids = [...pids].sort((a, b) => a - b)
-        assert.deepStrictEqual(pids, sortedPids)
-    })
-})