Declare dependency on json 2.4.0+ #3140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I see. The gemspec isn't loaded by the |
If the gems use `JSON.load_file` and are compatible with Ruby >= 2.5 they must declare that they require `json 2.4.0` otherwise they may get a much older version.
byroot
force-pushed
the
fix-json-dependency
branch
from
39c169b
to
77ac727
Compare
byroot
commented
Nov 6, 2024
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| source 'https://rubygems.org' | |||
|
|
|||
| gemspec path: "gems/aws-sdk-core/" | |||
There was a problem hiding this comment.
This should hopefully do the trick.
|
🍏 |
|
Hi! Due to the structure of how we run specs that involves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the gems use
JSON.load_fileand are compatible with Ruby >= 2.5 they must declare that they requirejson 2.4.0otherwise they may get a much older version.cc @jterapin, I don't know this project enough to know if
aws-sdk-coreis the right gemspec to add the dependency to, but that should solve your issues.