Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add imds asg target lifecycle hook #825

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add imds asg target lifecycle hook #825

wants to merge 2 commits into from

Conversation

pete911
Copy link

@pete911 pete911 commented May 19, 2023

Issue #, if available:
ASG target lifecycle hook is already available in instance metadata service. This pull request adds it to IMDS option.
Description of changes:
Adding ASG Termination Lifecycle Hook to IMDS Processor.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pete911 pete911 requested a review from a team as a code owner May 19, 2023 19:58
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jun 7, 2023
@pete911 pete911 mentioned this pull request Jun 8, 2023
Open
@pete911
Copy link
Author

pete911 commented Jun 8, 2023 •
edited

I have create issue as well to discuss/describe this PR - resolves #837

@github-actions github-actions bot removed the stale Issues / PRs with no activity label Jun 8, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jun 24, 2023
@pete911
Copy link
Author

pete911 commented Jun 24, 2023

any update on this? If it is not required, I can close the PR and issue.

@github-actions github-actions bot removed the stale Issues / PRs with no activity label Jun 25, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jul 10, 2023
@github-actions
Copy link

This PR was closed because it has become stale with no activity.

@github-actions github-actions bot closed this Jul 16, 2023
@jillmon jillmon added stalebot-ignore To NOT let the stalebot update or close the Issue / PR and removed stale Issues / PRs with no activity labels Jul 18, 2023
@jillmon jillmon reopened this Jul 18, 2023
@cjerad cjerad self-requested a review July 25, 2023 15:43
@ChristopherEdwardsNTC
Copy link

This would be super helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjerad cjerad Awaiting requested review from cjerad

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stalebot-ignore To NOT let the stalebot update or close the Issue / PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pete911 @ChristopherEdwardsNTC @jillmon