Per queue config + ENV config #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullermp
reviewed
Nov 27, 2024
| :shutdown_timeout, :client, :logger, | ||
| :async_queue_error_handler, :message_group_id | ||
| GLOBAL_ENV_CONFIGS = %i[ | ||
| threads backpressure |
There was a problem hiding this comment.
nit - single line or multiline all
|
|
||
| # Don't use this method directly: Configuration is a singleton class, use | ||
| # +Aws::ActiveJob::SQS.config+ to access the singleton config. | ||
| # | ||
| # This class provides a Configuration object for AWS ActiveJob | ||
| # by pulling configuration options from Runtime, the ENV, a YAML file, |
There was a problem hiding this comment.
I think ENV should take precedence over YAML, so that you can set ENV for the config file location. See how this was done in the sessionstore gem recently.
| @@ -87,12 +111,24 @@ class Configuration | |||
|
|
|||
| def initialize(options = {}) | |||
There was a problem hiding this comment.
This style/approach reads a lot cleaner IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#4 #3
Description of changes:
Adds configuration per queue and allows configuration through the environment for both global and queue specific values.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.