Adds steps to install terraform and configure AWS credentials #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing terraform and configuring AWS credentials are required to complete step 7
khanhntd
approved these changes
Apr 13, 2023
SaxyPandaBear
approved these changes
Apr 24, 2023
| @@ -281,7 +287,7 @@ Outputs: | |||
| [reference of how to create role](https://github.com/aws-actions/configure-aws-credentials) | |||
|
|
|||
| ## 7. Setup the integration test resources | |||
| 1. Navigate to your fork | |||
| 1. Fork amazon-cloudwatch-agent-test(or you can just download the terraform folder) | |||
There was a problem hiding this comment.
This should probably be clarified. Also, I don't think there's really any good reason to download the folder itself, without setting up the git repo locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing terraform and configuring AWS credentials are required to complete step 7
Description of the issue
Step 7 cannot be completed if terraform is not installed and AWS credential is not previously configured
Description of changes
Add steps to have the users run through the steps as prerequisite to prevent the issues.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Manually tested