Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable storageEncrypted option for vector store #299

Closed
wants to merge 1 commit into from

Conversation

drskur
Copy link

@drskur drskur commented May 8, 2024

Issue #, if available:

Description of changes:
enable storageEncrypted for vector store

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@statefb
Copy link
Contributor

statefb commented May 8, 2024

@drskur Thank you for your contribution!
Encryption itself is an important feature, so I'm very grateful for it. However, if user run cdk deploy as is, the RDS will be replaced, which would be a destructive change for existing users. Therefore, I believe it is essential to have a migration guide, such as restoring from a snapshot. Could you please add a Markdown document with the steps outlined? It would also be extremely helpful if you could confirm that the data stored before and after following these steps is the same.
Please also include encryption for DynamoDB (this can be done by adding one line, and no migration is required).
Thank you for your assistance with this request.

@jeremylatorre
Copy link
Contributor

I agree for DynamoDB, message encryption should be a must have. I'm a little bit concerned about performance issues by adding encryption in vectorStore.

@statefb statefb mentioned this pull request May 27, 2024
@statefb statefb closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants