Windows Node Group Support, Upgrade Grafana Operator, Add SecretRef to Flux and Upgrade VPC CNI. #749
Conversation
elamaran11
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103 and
youngjeong46
as code owners
There was a problem hiding this comment.
@elamaran11 do you mind outlining a solution with blueprints that shows how to create that secret in the first place, make it a dependency for the flux add-on and inject?
@shapirov103 Added doc update for this comment. |
|
/do-e2e-tests |
elamaran11
changed the title
docs/addons/fluxcd.md
Outdated
| @@ -29,6 +29,10 @@ const blueprint = blueprints.EksBlueprint.builder() | |||
| .build(app, 'my-stack-name'); | |||
| ``` | |||
|
|
|||
| ## Secret Management for private Git repositories | |||
There was a problem hiding this comment.
Have you tried it? I am not sure how exactly dependency is handled between aws provider, secret creation and flux installation.
There was a problem hiding this comment.
Yeah, i did try to create secret with external secrets to access a repo.
| userData: userData, | ||
| } | ||
| } | ||
| addGenericNodeGroup(), |
There was a problem hiding this comment.
Nice, thank you for doing this!
Fixed all lint issues, |
|
/do-e2e-tests |
Issue #, if available:
Description of changes:
This PR takes care of Upgrading Grafana Operator, Adding SecretRef to Flux and Upgrading VPC CNI.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.