Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag for deploy to isolated subnet #1075

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bezdomniy
Copy link

Issue #, if available:

Description of changes:
Add support for deploying Cluster resource in an isolated subnet. CDK EKS already supports deployment in an isolated subnet and this is describes in this example: https://github.com/aws-samples/aws-cdk-examples/tree/main/java/eks/private-cluster. This PR just adds an "isolatedCluster" flag, which adds Cluster props to based on the example.

Tested and deployed successfully.

Note that given the lack of internet access, addon's which require access to public repositories (like AwsLoadBalancerControllerAddOn) cannot be used.

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bezdomniy great work, definitely makes it more convenient to create isolated clusters. Implementation looks straightforward to me.

I will need to test it out, and atm our examples cluster is already overloaded with different use cases, so I will run it manually.

Please add your test case (functional) to https://github.com/aws-quickstart/cdk-eks-blueprints/blob/main/examples/examples.ts.
We are building an approach to run multiple e2e validation flows, so once it is in the codified form, it will be easy for me to migrate it to the fully automated approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants