Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials code in NeuronSDK 2.21 release #41

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

aws-qieqingy
Copy link
Contributor

Issue #, if available:

N/A

Description of changes:

  1. Fix typos
  2. Add tutorial code for Single program, multiple data tensor addition using multiple Neuron Cores

Testing:

These code has been tested against trn2.

Pull Request Checklist

  • I have filled in all the required field in the template
  • I have tested locally that all the tests pass
  • By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

Copy link

github-actions bot commented Jan 6, 2025

Please download and review the generated API doc at https://github.com/aws-neuron/nki-samples/actions/runs/12636915643

JonathanHenson
JonathanHenson previously approved these changes Jan 6, 2025
@@ -78,7 +78,7 @@ def np_average_pool_2D(in_tensor, pool_size):

print(in_tensor, out_nki, out_np)

match = (out_nki == out_np).all()
match = (out_nki == out_nki).all()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly unrelated to this PR, but this new code looks wrong...
where is this coming from?

Copy link

@ggumen ggumen Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like what's in dev branch internally has been wrong for 5 months, but what's in nki-samples is correct somehow. Probably shouldn't merge this line change in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, let's update the internal repo. There was a PR fixing this issue before. It didn't got port back into the internal repo. I will drop this line.

Copy link

github-actions bot commented Jan 6, 2025

Please download and review the generated API doc at https://github.com/aws-neuron/nki-samples/actions/runs/12641533510

@aws-qieqingy aws-qieqingy merged commit c72a66b into main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants