-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorials code in NeuronSDK 2.21 release #41
Conversation
Please download and review the generated API doc at https://github.com/aws-neuron/nki-samples/actions/runs/12636915643 |
@@ -78,7 +78,7 @@ def np_average_pool_2D(in_tensor, pool_size): | |||
|
|||
print(in_tensor, out_nki, out_np) | |||
|
|||
match = (out_nki == out_np).all() | |||
match = (out_nki == out_nki).all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly unrelated to this PR, but this new code looks wrong...
where is this coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like what's in dev branch internally has been wrong for 5 months, but what's in nki-samples is correct somehow. Probably shouldn't merge this line change in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, let's update the internal repo. There was a PR fixing this issue before. It didn't got port back into the internal repo. I will drop this line.
5ecf8af
to
460483d
Compare
Please download and review the generated API doc at https://github.com/aws-neuron/nki-samples/actions/runs/12641533510 |
Issue #, if available:
N/A
Description of changes:
Testing:
These code has been tested against trn2.
Pull Request Checklist