go1.x to provided.al2 migration #230
Conversation
| Handler: bootstrap | ||
| Runtime: provided.al2 | ||
| Architectures: | ||
| - x86_64 |
There was a problem hiding this comment.
is there a reason this is only x86_64?
There was a problem hiding this comment.
It wasn't clear to me what to do here, particularly as it's an example.
| @@ -15,6 +15,13 @@ Resources: | |||
| Principal: | |||
| Service: resources.cloudformation.amazonaws.com | |||
| Action: sts:AssumeRole | |||
| Condition: | |||
There was a problem hiding this comment.
do we need the extra condition?
There was a problem hiding this comment.
This is pulled from cloudformation-cli
|
Also worth noting provided.al2023 just came out too. https://docs.aws.amazon.com/lambda/latest/dg/runtimes-custom.html https://aws.amazon.com/blogs/compute/introducing-the-amazon-linux-2023-runtime-for-aws-lambda/ |
|
@kddejong I followed the Migration guide published in July, it uses I couldn't figure-out how to build this with options, or how |
|
If we can rebase to master the CI/CD issues should resolve itself. |
|
@kddejong rebase done |
|
looks like there is an issue with the end of file for one of the files fix end of files.........................................................Failed
Fixing examples/github-repo/makebuild |
|
2 of the generated example files were missing from .gitignore, I've deleted them from git and updated .gitignore- that was causing the EOF problem. |
Still failing CI: |
|
That's interesting- |
|
@msummers-nr thank you for your contribution. |
Issue #229 :
Description of changes: Changes required to migrate from go1.x to provided.al2
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.