Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(liveness): Add gamma env #5255

Merged
merged 19 commits into from
May 22, 2024
Merged

chore(liveness): Add gamma env #5255

merged 19 commits into from
May 22, 2024

Conversation

esauerbo
Copy link
Contributor

@esauerbo esauerbo commented May 15, 2024

Description of changes

  • Add additional lambdas that hit the LivenessFE gamma endpoint and use the Liveness JS client with no-light flow
  • Update liveness example to hit new lambda endpoints and gamma streaming endpoint
  • Temporarily disable publish on push to liveness/alpha
  • Update CustomWebSocketFetchHandler to work with new sdk (copied from their websocket-fetch-handler with the addition of our custom logic)
  • Add ability to select challengeType from the frontend

As discussed offline we'll be pulling in the new JS SDK locally for now so that's not part of this PR

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented May 15, 2024

⚠️ No Changeset found

Latest commit: a0eb4cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@esauerbo esauerbo added the run-tests Adding this label will trigger tests to run label May 15, 2024
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label May 15, 2024
thaddmt
thaddmt previously approved these changes May 21, 2024
const {
getLivenessResponse,
createLivenessSessionApiError,
createLivenessSessionApiData,
createLivenessSessionApiLoading,
handleGetLivenessDetection,
stopLiveness,
} = useLiveness();
} = useLiveness(challengeType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker: how does this work with connection opening on the camera check screen? Would we need to re-open a request each time we change the challenge type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it creates the session with the default FaceMovementAndLight but then if you change the selection it calls mutate with the start key and creates a new session with the new challenge. I believe this basically marks the data as invalid so makes the same api call again. I'm not super familiar with swr so definitely open to cleaner/better ways of doing that though.

Screen.Recording.2024-05-21.at.9.45.54.AM.mov

@esauerbo esauerbo merged commit e49a972 into liveness/alpha May 22, 2024
31 checks passed
@esauerbo esauerbo deleted the liveness/nolight-env branch May 22, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants