-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(liveness): Add gamma env #5255
Conversation
|
const { | ||
getLivenessResponse, | ||
createLivenessSessionApiError, | ||
createLivenessSessionApiData, | ||
createLivenessSessionApiLoading, | ||
handleGetLivenessDetection, | ||
stopLiveness, | ||
} = useLiveness(); | ||
} = useLiveness(challengeType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker: how does this work with connection opening on the camera check screen? Would we need to re-open a request each time we change the challenge type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it creates the session with the default FaceMovementAndLight
but then if you change the selection it calls mutate
with the start key and creates a new session with the new challenge. I believe this basically marks the data as invalid so makes the same api call again. I'm not super familiar with swr
so definitely open to cleaner/better ways of doing that though.
Description of changes
liveness/alpha
As discussed offline we'll be pulling in the new JS SDK locally for now so that's not part of this PR
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addedsideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.