-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add @mainactor attribute to DeviceInfo #3712
Closed
phantumcode
wants to merge
14
commits into
enhancement/swift6_update
from
enhancement/deviceInfo_strict_concurrency
Closed
chore: add @mainactor attribute to DeviceInfo #3712
phantumcode
wants to merge
14
commits into
enhancement/swift6_update
from
enhancement/deviceInfo_strict_concurrency
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## enhancement/swift6_update #3712 +/- ##
=============================================================
+ Coverage 68.37% 72.69% +4.31%
=============================================================
Files 1089 732 -357
Lines 37653 31115 -6538
=============================================================
- Hits 25747 22620 -3127
+ Misses 11906 8495 -3411
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
had a problem deploying
to
IntegrationTest
May 28, 2024 15:05
— with
GitHub Actions
Error
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:19
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:19
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:19
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:19
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
phantumcode
temporarily deployed
to
IntegrationTest
May 31, 2024 15:44
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
UIDevice is marked with
@MainActor
attribute resulting in errors when calling it from synchronous non-isolated context.Resolve strict concurrency error by updating
DeviceInfo
and callingUIDevice
from main-actor isolated context.This results in changes in AWSCognitoAuthPlugin and InternalAWSPinpoint so that calls to DeviceInfo is executed in an async context.
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.