Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add support for GraphQL filter attributeExists #3484

Merged
merged 5 commits into from
Jul 30, 2024
Merged

feat(api): add support for GraphQL filter attributeExists #3484

merged 5 commits into from
Jul 30, 2024

Conversation

5d
Copy link
Member

@5d 5d commented Jan 26, 2024 •
edited
Loading

Issue #

Description

  • add support for AppSync GraphQL filter attributeExists
  • fix query filter with nil value.
  • optimize the SQL query generation for attributeExists and eq(nil)/ne(nil)

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:44 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:44 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:44 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:44 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:44 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:44 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:45 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:45 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:45 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:45 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:45 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:45 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:45 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest July 30, 2024 19:45 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
Func QueryOperator.evaluate(target:) has parameter 0 type change from Any to Any?
Func QueryFieldOperation.attributeExists(_:) has been added as a protocol requirement

@github-actions github-actions bot requested a review from a team as a code owner July 30, 2024 19:49
@5d 5d requested a review from lawmicha July 30, 2024 20:48
@5d 5d merged commit 2c3ed0c into main Jul 30, 2024
@5d 5d deleted the 5d/graphql-filter-support branch July 30, 2024 21:17
yaroluchko pushed a commit to yaroluchko/amplify-swift-keychain-sharing that referenced this pull request Aug 2, 2024
@5d @aws-amplify-ops @yaroluchko
feat(api): add support for GraphQL filter attributeExists (aws-amplif…
f9c7288 
…y#3484)

* add support for GraphQL filter attributeExists

* fix(datastore): deduplicate SQL statement of attributeExists and eq/ne

* fix(datastore): flacky unit test

* Update API dumps for new version

---------

Co-authored-by: aws-amplify-ops <[email protected]>
5d added a commit that referenced this pull request Aug 8, 2024
@5d
Revert "feat(api): add support for GraphQL filter attributeExists (#3484
aff4a88 
)"

This reverts commit 2c3ed0c.
@5d 5d mentioned this pull request Aug 8, 2024
Merged
5d added a commit that referenced this pull request Aug 8, 2024
@5d
Revert "feat(api): add support for GraphQL filter attributeExists (#3484
694aae0 
)" (#3803)

This reverts commit 2c3ed0c.
@5d 5d restored the 5d/graphql-filter-support branch August 27, 2024 01:04
@5d 5d mentioned this pull request Aug 27, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruisebas ruisebas ruisebas approved these changes

@lawmicha lawmicha Awaiting requested review from lawmicha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@5d @codecov-commenter @lawmicha @ruisebas @aws-amplify-ops