Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for task and execution role ARNs in action.yml and … #293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ inputs:
command:
description: 'The command used by ECS to start the container image'
required: false
task-role-arn:
description: 'The ARN of the IAM role that the ECS container will assume'
required: false
execution-role-arn:
description: 'The ARN of the IAM role that the ECS task execution role will assume'
required: false
outputs:
task-definition:
description: 'The path to the rendered task definition file'
Expand Down
12 changes: 12 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ async function run() {
const logConfigurationOptions = core.getInput("log-configuration-options", { required: false });
const dockerLabels = core.getInput('docker-labels', { required: false });
const command = core.getInput('command', { required: false });
const taskRoleArn = core.getInput('task-role-arn', { required: false });
const executionRoleArn = core.getInput('execution-role-arn', { required: false });


// Parse the task definition
const taskDefPath = path.isAbsolute(taskDefinitionFile) ?
Expand All @@ -38,6 +41,7 @@ async function run() {
}
containerDef.image = imageURI;


if (command) {
containerDef.command = command.split(' ')
}
Expand Down Expand Up @@ -121,6 +125,14 @@ async function run() {
})
}

if (taskRoleArn) {
taskDefContents.taskRoleArn = taskRoleArn;
}

if (executionRoleArn) {
taskDefContents.executionRoleArn = executionRoleArn;
}

// Write out a new task definition file
var updatedTaskDefFile = tmp.fileSync({
tmpdir: process.env.RUNNER_TEMP,
Expand Down