Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support secrets in render task definition #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yehudacohen
Copy link

Issue #, if available:
#20
Description of changes:
Add ability to add secrets to task definition. There is already a pull request here #143 which tries to do this, but it isn't backward compatible. This pull request is. It also doesn't add tests which this PR does.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kroehre
Copy link

kroehre commented Apr 26, 2022

👍 we'd love to use this feature. What's blocking?

@cairesvs
Copy link

cairesvs commented Nov 6, 2023

Hi 👋 Any updates about when this will be merged? I think it's a needed feature 🙏

fgreinus added a commit to circus-kitchens/amazon-ecs-render-task-definition that referenced this pull request Jan 24, 2024
taken from aws-actions#152

Signed-off-by: Florian Greinus <[email protected]>
@canhassancode
Copy link

Hi there, any update on this?

@amazreech
Copy link
Contributor

amazreech commented May 10, 2024

Hi @yehudacohen, thank you so much for your contribution. Apologies on the delay.
We will be working on reviewing Pull Requests on the repository. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please be sure to run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants