-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO PWM #419
base: master
Are you sure you want to change the base?
SSO PWM #419
Conversation
f3ba629
to
ee93f29
Compare
ee93f29
to
cb89a94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @darkdragon-001 , since #459 we have new contribution guidelines in place, could you please take some time to answer the following questions as best you can? Thanks
- Why is it awesome?
- Have you used it? For how long?
- Is this in a personal or professional setup?
- How many devices/users/services/... do you manage with it?
- Biggest pros/cons compared to other solutions?
Why is it awesome?
Have you used it? For how long? Is this in a personal or professional setup? How many devices/users/services/... do you manage with it? Biggest pros/cons compared to other solutions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Waiting for additional reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely convinced that this should be included in the list. Firstly, it appears that you may not have extensive experience with it yourself. Additionally, when I review the issue tab, it seems that there are numerous unresolved issues, and the application receives only minor updates, mainly related to dependency updates.
@Rabenherz112 I do see regular commits including bug fixes and huge refactorings in the commit history: https://github.com/pwm-project/pwm/commits/master. To me it seems like the project already has a lot of great features. If people want additional features they are encouraged to send a PR with such addition and the maintainer seems very open to integrate proposed changes. Of course just opening an issue does not give any guarantee that someone else will work on it in their free time without any sort of reward. |
I share your perspective that the application appears to be quite mature and doesn't require as much maintenance as some other applications. However, it does strike me as somewhat unusual that there are numerous open issues dating all the way back to 2016. That's why I am a bit unsure about it. I wholeheartedly agree that opening issues doesn't guarantee that they will be fixed or implemented, but there seems to be a limited response from the main maintainer regarding such issues. Additionally, certain issues appear to have been open for multiple years without any response, such as #57, #536, and several others (though I'm uncertain if this might be attributable to user errors). |
Thank you for taking the time to work on a PR for Awesome-Sysadmin!
To ensure your PR is dealt with swiftly please check the following:
Demo
andClients
are optional.Do not add a duplicate
Source code
link if it is the same as the main link.Keep the short description under 80 characters and use sentence case
for it, even if the project's webpage or readme uses another capitalisation.
Demo
links should only be used for interactive demos, i.e. not video demonstrations.- [Name](http://homepage/) - Short description, under 250 characters, sentence case. ([Demo](http://url.to/demo), [Source Code](http://url.of/source/code), [Clients](https://url.to/list/of/related/clients-or-apps)) `License` `Language`
Language
tag is the main server-side requirement for the software. Don't include frameworks or specific dialects.Suggested titles: "Add aaa to bbb" for adding software aaa to section bbb,
"Remove aaa from bbb" for removing, "Fix license for aaa", etc.
Why it is awesome
This provider is so awesome because it allows you to maintain a single account but provide many independent services.