Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix category position #296

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix category position #296

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0878126
Merge pull request #4 from avstudnitz/develop
mbijnsdorp Mar 1, 2016
afa9043
Set correct category position if not included in data
mbijnsdorp Mar 1, 2016
a458252
Merge branch 'develop' into fix-category-position
mbijnsdorp Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 60 additions & 17 deletions src/app/code/community/AvS/FastSimpleImport/Model/Import/Entity/Category.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,11 @@ class AvS_FastSimpleImport_Model_Import_Entity_Category extends Mage_ImportExpor

protected $_defaultAttributeSetId = 0;

/**
* @var Mage_Catalog_Model_Resource_Category
*/
protected $_categoryResource;

public function setIgnoreDuplicates($ignore)
{
$this->_ignoreDuplicates = (boolean) $ignore;
Expand Down Expand Up @@ -256,18 +261,18 @@ public function __construct()
{
parent::__construct();

/* @var $categoryResource Mage_Catalog_Model_Resource_Category */
$categoryResource = Mage::getModel('catalog/category')->getResource();
$this->_categoryResource = $categoryResource;
$this->_entityTable = $categoryResource->getEntityTable();

$this
->_initOnTabAttributes()
->_initWebsites()
->_initStores()
->_initCategories()
->_initAttributes()
->_initAttributeSetId();

/* @var $categoryResource Mage_Catalog_Model_Resource_Category */
$categoryResource = Mage::getModel('catalog/category')->getResource();
$this->_entityTable = $categoryResource->getEntityTable();

}

/**
Expand Down Expand Up @@ -375,11 +380,14 @@ protected function _initCategories()
}
$index = $this->_implodeEscaped('/', $path);

$this->_categoriesWithRoots[$rootCategoryName][$index] = array(
'entity_id' => $category->getId(),
'path' => $category->getPath(),
'level' => $category->getLevel(),
'position' => $category->getPosition()
$this->_categoriesWithRoots[$rootCategoryName][$index] = new Varien_Object(
array(
'entity_id' => $category->getId(),
'path' => $category->getPath(),
'level' => $category->getLevel(),
'position' => $category->getPosition(),
'next_child_position' => $this->_getCategoryNextChildPosition($category->getPath())
)
);

//allow importing by ids.
Expand All @@ -394,6 +402,26 @@ protected function _initCategories()
return $this;
}

/**
* Get the position of a category's next child using the path of the category
*
* @param string $path
*
* @return int|string
*/
protected function _getCategoryNextChildPosition($path)
{
static $method;
if (is_null($method)) {
$class = new ReflectionClass('Mage_Catalog_Model_Resource_Category');
$method = $class->getMethod('_getMaxPosition');
$method->setAccessible(true);
}

$position = $method->invoke($this->_categoryResource, $path);
return $position + 1;
}

/**
* Initialize stores hash.
*
Expand Down Expand Up @@ -570,16 +598,24 @@ protected function _saveCategories()
'level' => $parentCategory['level'] + 1,
'created_at' => empty($rowData['created_at']) ? now()
: gmstrftime($strftimeFormat, strtotime($rowData['created_at'])),
'updated_at' => now(),
'position' => $rowData['position']
'updated_at' => now()
);

if (isset($this->_categoriesWithRoots[$rowData[self::COL_ROOT]][$rowData[self::COL_CATEGORY]]))
{ //edit

$entityId = $this->_categoriesWithRoots[$rowData[self::COL_ROOT]][$rowData[self::COL_CATEGORY]]['entity_id'];
$path = $parentCategory['path'] .'/'.$entityId;
$position = $this->_categoriesWithRoots[$rowData[self::COL_ROOT]][self::COL_CATEGORY]['position'];
Copy link
Contributor

@barbazul barbazul Jun 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the second level key in the array was meant to be $rowData[self::COL_CATEGORY]

if ($path !== $this->_categoriesWithRoots[$rowData[self::COL_ROOT]][self::COL_CATEGORY]['path'] && empty($rowData['position'])) {
// category moved to a new parent
$position = $parentCategory['next_child_position'];
$parentCategory['next_child_position'] += 1;
$this->_categoriesWithRoots[$rowData[self::COL_ROOT]][self::COL_CATEGORY]['path'] = $path;
}

$entityRow['entity_id'] = $entityId;
$entityRow['path'] = $parentCategory['path'] .'/'.$entityId;
$entityRow['position'] = !empty($rowData['position']) ? $rowData['position'] : $position;
$entityRowsUp[] = $entityRow;
$rowData['entity_id'] = $entityId;
} else
Expand All @@ -589,14 +625,21 @@ protected function _saveCategories()
$entityRow['path'] = $parentCategory['path'] .'/'.$entityId;
$entityRow['entity_type_id'] = $this->_entityTypeId;
$entityRow['attribute_set_id'] = $this->_defaultAttributeSetId;
$entityRow['position'] = !empty($rowData['position']) ? $rowData['position'] : $parentCategory['next_child_position'];
$entityRowsIn[] = $entityRow;

$this->_newCategory[$rowData[self::COL_ROOT]][$rowData[self::COL_CATEGORY]] = array(
'entity_id' => $entityId,
'path' => $entityRow['path'],
'level' => $entityRow['level']
$this->_newCategory[$rowData[self::COL_ROOT]][$rowData[self::COL_CATEGORY]] = new Varien_Object(
array(
'entity_id' => $entityId,
'path' => $entityRow['path'],
'level' => $entityRow['level'],
'next_child_position' => 1
)
);

if (empty($rowData['position'])) {
$parentCategory['next_child_position'] += 1;
}
}
}

Expand Down