Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to write test results to a file as JSON #55

Merged
merged 4 commits into from
Mar 4, 2020
Merged

Conversation

aviaviavi
Copy link
Owner

closes #53

@aviaviavi
Copy link
Owner Author

@Rashadse let me know what you think

@ghost
Copy link

ghost commented Feb 28, 2020

nice!
for some reason the time elapsed for each case says wrong values like 18 or 15 and so on, it should be 0.1 and 0.2 etc like you did in the time feature. is this a bug?

@aviaviavi
Copy link
Owner Author

Oh good catch. Internally, elapsed time is tracked in milliseconds, I forgot to have the conversion in there. Will change

@aviaviavi
Copy link
Owner Author

cc @Rashadse

@ghost
Copy link

ghost commented Mar 2, 2020

Hello again,
the latest fix shows the correct number but in the wrong form, we are getting 1.0e-2 instead of the simplified form

@aviaviavi
Copy link
Owner Author

Interestingly, I actually can't seem to reproduce this. Is this happening reliably? What system are you on?

@ghost
Copy link

ghost commented Mar 2, 2020

I am on ubuntu

@aviaviavi
Copy link
Owner Author

Still can't reproduce, but try again and let me know if that helped

@ghost
Copy link

ghost commented Mar 3, 2020

what we are getting is the scientific notation of the time "elapsedTimeSeconds": 4.6e-2
this is actually fine for us
i think we got what we wanted
you can go ahead and merge the commit

@aviaviavi
Copy link
Owner Author

Weird, I tried this out on ubuntu and I still can't seem to get it to spit out scientific notation. If this works for you I'll merge for now. We can circle back to it if needed.

@aviaviavi aviaviavi merged commit 2ed78c7 into master Mar 4, 2020
@aviaviavi aviaviavi deleted the json-output branch March 4, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging summary of testcases
1 participant