Replace arrgv with args-tokenizer #3364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently published args-tokenizer package. We use it at Webstudio for parsing cURL on paste. Used at https://github.com/antfu-collective/bumpp. There are two benefits - published with type definitions - parser is forgiving to unclosed quotes which can be more user friendly The package also is esm only but used only in CLI so should not be a problem with commonjs. Though I can add cjs support if necessary. https://github.com/TrySound/args-tokenizer
|
I don't think silently forgiving invalid input is an improvement. |
|
Will "strict" option work for you? I can add it |
|
Upgraded to new strict by default version and reverted test changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently published args-tokenizer package. We use it at Webstudio for parsing cURL on paste. Also used at https://github.com/antfu-collective/bumpp.
There are a few benefits
parser is forgiving to unclosed quotes which can be more user friendlyThe package also is esm only but used only in CLI so should not be a problem with commonjs. Though I can add cjs support if necessary.
https://github.com/TrySound/args-tokenizer