Standardize P-Chain tx visitor order #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
While working on multiple tx visitors, I found it really annoying to need to jump around files with no real rhyme/reason. This PR standardizes the P-chain tx visitors to be aligned with their tx typeIDs.
This is a holistic PR that is intended to reduce the diff for some of the later ACP-77 PRs which did this change ad-hoc.
How this works
Just moves code around, there are no logical changes.
The reason there are +7 added lines is for the comments added to the
vms/platformvm/txs/visitor.gofile.How this was tested
CI
Need to be documented in RELEASES.md?
No.