fix: do not throw on plugins names starting with @

src/install-plugins.ts

@@ -2,6 +2,7 @@ import { spawn } from 'node:child_process'
 import fs from 'node:fs'
 
 import { PLUGINS_PACKAGE_JSON_PATH, PLUGIN_STORE_PATH } from './paths.js'
+import { splitPluginNameAndVersion } from './utils.js'
 
 const npmExecutable = process.platform.startsWith('win') ? 'npm.cmd' : 'npm'
 
@@ -33,10 +34,8 @@ function filterPluginsToInstall(pluginNames: string[]) {
  const installedPlugins: string[] = []
 
  pluginNames.forEach(rawPluginName => {
- let [pluginName, pluginVersion] = rawPluginName.split('@') as [
- string,
- string | undefined,
- ]
+ let { name: pluginName, version: pluginVersion } =
+ splitPluginNameAndVersion(rawPluginName)
  if (
  pluginVersion &&
  (pluginVersion.startsWith('^') || pluginVersion.startsWith('~'))

src/main.ts

@@ -3,6 +3,7 @@ import { resolve } from 'import-meta-resolve'
 import { installPlugins } from './install-plugins.js'
 import { parseArgs } from './parse-args.js'
 import { PLUGINS_PACKAGE_JSON_PATH } from './paths.js'
+import { splitPluginNameAndVersion } from './utils.js'
 
 export async function run(args: string[]) {
  const { prettierArgs, pluginNames } = parseArgs(args)
@@ -20,7 +21,7 @@ export async function run(args: string[]) {
 
  const pnpPlugins: string[] = []
  pluginNames.forEach(pluginName => {
- pluginName = pluginName.split('@')[0]
+ pluginName = splitPluginNameAndVersion(pluginName).name
  const resolved = resolve(pluginName, PLUGINS_PACKAGE_JSON_PATH.href)
  pnpPlugins.push('--plugin', resolved)
  })

src/parse-args.ts

@@ -1,3 +1,5 @@
+import { splitPluginNameAndVersion } from './utils.js'
+
 function extendPluginName(shortName: string) {
  return 'prettier-plugin-' + shortName
 }
@@ -11,7 +13,9 @@ export function parseArgs(args: string[]): {
 
  function pushPluginName(pluginName: string) {
  const isDuplicated = pluginNames.some(
- name => name.split('@')[0] === pluginName.split('@')[0],
+ name =>
+ splitPluginNameAndVersion(name).name ===
+ splitPluginNameAndVersion(pluginName).name,
  )
 
  if (isDuplicated) {

src/utils.ts

@@ -0,0 +1,19 @@
+export function splitPluginNameAndVersion(packageName: string): {
+ name: string
+ version: string | undefined
+} {
+ let name = ''
+
+ if (packageName.startsWith('@')) {
+ name = '@'
+ packageName = packageName.slice(1)
+ }
+
+ name += packageName.split('@')[0]
+ const version = packageName.split('@')[1]
+
+ return {
+ name,
+ version,
+ }
+}

tests/integration/__tests__/cli.test.ts

@@ -162,6 +162,21 @@ describe('prettier-pnp cli', () => {
  expect(packageJson).toMatchSnapshot()
  })
 
+ it('should install plugin with a name starting with @', () => {
+ const args1 = ['--pnp', '@prettier/plugin-php', 'index.js']
+
+ const result = runPrettierPnpCli(...args1)
+ expect(result.status).toEqual(0)
+ expect(result.stdout.split('\n').slice(0, 5).join('\n'))
+ .toMatchInlineSnapshot(`
+ "
+ ---- Installing plugins ----
+
+ - @prettier/plugin-php
+ "
+ `)
+ })
+
  it('should not try to install already installed plugins', () => {
  const args1 = ['--pn', 'curly', 'index.js']
  const args2 = ['--pn', 'curly', '--pn', 'organize-imports', 'index.js']