Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom pluralize method in application_controller.rb #2082

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

20wildmanj
Copy link
Contributor

Description

  • Remove custom pluralize method as there already exists a method provided by rails which is being used by views code.
  • The pluralize code doesn't even work with controllers (where it was being used, such as in autograde.rb),as it only handles strings but was being fed integers which caused error such as this when trying to run regradeAll

Screenshot 2024-02-10 at 2 42 03 PM

Motivation and Context

  • the pluralize code was throwing an error unrelated to regradeAll which was not caught

How Has This Been Tested?

  • Run regradeAll, see that it runs successfully and pluralizes students
    Screenshot 2024-02-10 at 2 47 52 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

Copy link
Contributor

coderabbitai bot commented Feb 10, 2024

Warning

Rate Limit Exceeded

@20wildmanj has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 3 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 43343a1 and bc2d59d.

Walkthrough

The recent update involves the removal of the pluralize method from the ApplicationController and its replacement with the ActionController::Base.helpers.pluralize method in specific files. This adjustment ensures the correct pluralization of terms in flash messages depending on the count of items, enhancing the accuracy and readability of user feedback within the application.

Changes

File Change Summary
app/controllers/application_controller.rb Removed the pluralize method.
app/controllers/assessment/autograde.rb Replaced calls to pluralize with ActionController::Base.helpers.pluralize for correct pluralization in flash messages.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@gitstream-cm gitstream-cm bot requested review from a team and jlge and removed request for a team February 10, 2024 19:50
@gitstream-cm gitstream-cm bot added the small Pull request is small label Feb 10, 2024
@gitstream-cm gitstream-cm bot requested a review from a team February 10, 2024 19:50
Copy link
Contributor

@jlge jlge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@20wildmanj 20wildmanj added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@20wildmanj 20wildmanj added this pull request to the merge queue Feb 19, 2024
Merged via the queue into master with commit 102a9a9 Feb 19, 2024
11 checks passed
@20wildmanj 20wildmanj deleted the joeywildman-fix-pluralize branch February 19, 2024 21:07
NicholasMy pushed a commit to UB-CSE-IT/Autolab that referenced this pull request Jan 9, 2025
…2082)

* Remove custom pluralize code as it is unnecessary and causing errors

* remove pluralize again (got readded in merge)

(cherry picked from commit 102a9a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants