address nit

autolab · Nov 1, 2023 · 09877e7 · 09877e7
1 parent d6791a7
commit 09877e7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/app/views/scoreboards/_error_icon.html.erb b/app/views/scoreboards/_error_icon.html.erb
@@ -0,0 +1,7 @@
+<td>
+  <div style="display: flex; align-content: center; justify-content: center;">
+    <i class="material-icons tooltipped" data-tooltip="Could not parse scoreboard entry">
+      error_outline
+    </i>
+  </div>
+</td>
diff --git a/app/views/scoreboards/show.html.erb b/app/views/scoreboards/show.html.erb
@@ -64,13 +64,7 @@
                 <% if grade[:entry].is_a?(Array) && grade[:entry][i] != "-" %>
                   <td><%= grade[:entry][i] %></td>
                 <% else %>
-                  <td>
-                    <div style="display: flex; align-content: center; justify-content: center;">
-                      <i class="material-icons tooltipped" data-tooltip="Could not parse scoreboard entry">
-                        error_outline
-                      </i>
-                    </div>
-                  </td>
+                  <%= render 'error_icon' %>
                 <% end %>
               <% end %>
             <% end %>
@@ -79,15 +73,9 @@
             <% if grade[:entry].is_a?(Array) && grade[:entry][i] != "-" %>
               <% grade[:entry].each do |column| %>
                 <td><%= column %></td>
-              <% end %>
+              <% end %>q
             <% else %>
-              <td>
-                <div style="display: flex; align-content: center; justify-content: center;">
-                  <i class="material-icons tooltipped" data-tooltip="Could not parse scoreboard entry">
-                    error_outline
-                  </i>
-                </div>
-              </td>
+              <%= render 'error_icon' %>
             <% end %>
           <% end %>
         </tr>