Treat popup value property when completing candidate

[tkf]

To manually test, execute this:

(defun actest-value-candidates ()
  ;; (name . value) -- see `ac-candidates-1'
  '(("foofoo" . "foo")
    ("foobar" . "bar")))

(ac-define-source actest-keywords
  '((candidates . (actest-value-candidates))))

(progn
  (pop-to-buffer (get-buffer-create "*actest*"))
  (auto-complete-mode +1)
  (erase-buffer)
  (insert "fo")
  (run-with-timer 0.1 nil #'auto-complete '(ac-source-actest-keywords)))

fixes #148

[tkf]

Wait sec, I am not sure about the last commit tkf@06acf91

[tkf]

I think this PR is ready for merge. But I want @m2ym to review it as it is a little bit large change. My concern is that the change in ac-candidates-1 (tkf@e256d26) might slows down completion as it creates a list as long as candidates every time. We can avoid this by adding "I don't use popup-item-value" flag as source attribute. Probably we should make it default.

@tjarvstrand, @jixiuf, as your issue reports (#168, #148) are fixed by this PR, feel free to try/review this.

[tjarvstrand]

Any progress on this? I'm sorry I haven't had the time to try this out, but I'll try to get around to it soon. :)

[syohex]

I have merged this patch. Please report us if there are any problems.

[syohex]

Sorry I revert this changes. This patch breaks auto-complete source whose candidates type
is cons such as ac-semantic-candidates. Because cdr value is set as value property
in candidate string.

This changes should apply only to popup-item object. But it is only a propertized string.
so we can't make a distinction between popup-item and normal propertized string.
Because popup-item may not have its specific property, such as popup-face.