Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter #3

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Add linter #3

merged 4 commits into from
Jul 17, 2023

Conversation

lepture
Copy link
Member

@lepture lepture commented Jul 17, 2023

Added flake8 and mypy. There are many issues found my mypy.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (460e5eb) 99.32% compared to head (e1be85d) 99.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          46       46           
  Lines        2379     2379           
  Branches      354      354           
=======================================
  Hits         2363     2363           
  Misses          8        8           
  Partials        8        8           
Flag Coverage Δ
unittests 99.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/joserfc/jws.py 100.00% <ø> (ø)
src/joserfc/rfc7516/types.py 100.00% <ø> (ø)
src/joserfc/rfc7517/models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lepture
Copy link
Member Author

lepture commented Jul 17, 2023

@Viicos Can you help me with the mypy configuration.

@Viicos
Copy link
Member

Viicos commented Jul 17, 2023

Would you like mypy to suceed first (by turning off some switches), so that we can gradually improve typing?

@lepture
Copy link
Member Author

lepture commented Jul 17, 2023

@Viicos sure. If you can join the discord sever, we can discuss about the typing on discord.

@lepture lepture merged commit e1be85d into main Jul 17, 2023
7 checks passed
@lepture
Copy link
Member Author

lepture commented Jul 17, 2023

I'll merge the code at first. Need to create a wip-mypy branch.

@lepture lepture deleted the feat-lint branch July 17, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants