Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework migration (Don't merge) #1059

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Framework migration (Don't merge) #1059

wants to merge 2 commits into from

Conversation

acwest
Copy link
Contributor

@acwest acwest commented Oct 28, 2024

🔧 Changes

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 74.12698% with 163 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (10728bf) to head (04be9d5).

Files with missing lines Patch % Lines
...l/framework/auth0/encryptionkeymanager/resource.go 79.08% 54 Missing and 24 partials ⚠️
internal/config/config.go 3.12% 62 Missing ⚠️
main.go 0.00% 12 Missing ⚠️
internal/framework/provider/mux_server.go 66.66% 4 Missing and 2 partials ⚠️
internal/framework/error/diag_error.go 81.25% 2 Missing and 1 partial ⚠️
internal/framework/provider/provider.go 97.56% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   89.41%   88.94%   -0.48%     
==========================================
  Files         126      130       +4     
  Lines       17464    17787     +323     
==========================================
+ Hits        15615    15820     +205     
- Misses       1309     1413     +104     
- Partials      540      554      +14     
Files with missing lines Coverage Δ
...al/framework/auth0/encryptionkeymanager/flatten.go 100.00% <100.00%> (ø)
internal/framework/provider/data_source.go 100.00% <100.00%> (ø)
internal/provider/provider.go 100.00% <ø> (ø)
internal/framework/provider/provider.go 97.56% <97.56%> (ø)
internal/framework/error/diag_error.go 81.25% <81.25%> (ø)
internal/framework/provider/mux_server.go 66.66% <66.66%> (ø)
main.go 0.00% <0.00%> (ø)
internal/config/config.go 65.48% <3.12%> (-30.05%) ⬇️
...l/framework/auth0/encryptionkeymanager/resource.go 79.08% <79.08%> (ø)

@acwest acwest force-pushed the framework-migration branch 6 times, most recently from b833775 to 36d88f8 Compare October 30, 2024 15:19
@acwest acwest force-pushed the framework-migration branch from 36d88f8 to 04be9d5 Compare October 31, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants