feat: update email validation pattern #1937
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aurelia/packages/validation/src/rule-provider.ts
Line 311 in 2fca6ea
const emailPattern = /^[a-zA-Z0-9.!#$%&'+/=?^_`{|}~-]+@a-zA-Z0-9?(?:.a-zA-Z0-9?)$/;
Not sure if this is the intended behavior.
At the moment the behaviour is like this
test -> not valid
test@ -> not valid
test@test -> valid
test@test. -> not valid
[email protected] -> valid
Should test@test also not be valid?
If yes, then changing the regex to something like this:
^[a-zA-Z0-9.!#$%&'+/=?^_`{|}~-]+@a-zA-Z0-9?(?:.a-zA-Z0-9?).[a-zA-Z0-9]{2,}$
I have change the emailpattern, please review it and merge my pull request