Fix empty domain handling in Email validation and add PHP 8.3/8.4 support #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure functions have correct type returns and optional parameters with default values.
This update improves the IDN to ASCII conversion by handling cases where the email address lacks a domain part or '@' symbol. By checking for these conditions, the function now gracefully returns the input as is, avoiding unnecessary warnings or errors during the conversion process.
Updated the continuous integration workflow to include PHP versions 8.3 and 8.4 in the testing matrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides two improvements:
Changes
idnToAsciimethod to handle empty domains properly