Modify Permutation to only allow actual permutations #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original definition of the
Permutation
class allowed some lists that were not actually permutations, such as[1, 1]
. This is because the constraints did require that all elements of the permutation array are valid indices into [1..n), but not that this mapping is bijective. Adding a reverseAllElem
constraint corrects this.Before this PR:
After this PR, these invocations are rejected with a type error.