Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mkrzero update #697

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Mkrzero update #697

merged 6 commits into from
Oct 2, 2023

Conversation

johngigantic
Copy link
Contributor

@johngigantic johngigantic commented Aug 17, 2023

Summary

[Update Arduino MKRZero from atsamd-hal v0.14.0 to 0.16.0]

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

If Adding a new Board (N/A)

If Adding a new cargo feature to the HAL (N/A)

@johngigantic
Copy link
Contributor Author

johngigantic commented Aug 17, 2023

With the latest 3 commits on top of the BSP changes, I've added @arkap's addition of a blinky_rtic example (#580) and updated it to work on top of my BSP changes. I'd be happy to get some review; it's cleaned up with respect to clippy, rustfmt, and all that, but I can add some more changes as desired.

If/when this gets merged, #580 can be closed out.

I've ran both the blinky_basic and blinky_rtic apps on the MkrZero successfully.

Copy link
Member

@sajattack sajattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajattack sajattack merged commit 72e40ff into atsamd-rs:master Oct 2, 2023
benvonhandorf pushed a commit to benvonhandorf/atsamd that referenced this pull request Nov 29, 2023
* Update atsamd-hal to 0.16 and add built-in pin definitions

* Add LED and VBatt sensor pins. Update each of 3 examples to use new atsamd-hal API

* Update version number and changelog

* arduino_mkrzero: add blinky_rtic example

Signed-off-by: Arne Kappen <[email protected]>

* fix fmt

Signed-off-by: Arne Kappen <[email protected]>

* Update blinky RTIC example to work with latest BSP changes

---------

Signed-off-by: Arne Kappen <[email protected]>
Co-authored-by: Arne Kappen <[email protected]>
benvonhandorf pushed a commit to benvonhandorf/atsamd that referenced this pull request Nov 29, 2023
* Update atsamd-hal to 0.16 and add built-in pin definitions

* Add LED and VBatt sensor pins. Update each of 3 examples to use new atsamd-hal API

* Update version number and changelog

* arduino_mkrzero: add blinky_rtic example

Signed-off-by: Arne Kappen <[email protected]>

* fix fmt

Signed-off-by: Arne Kappen <[email protected]>

* Update blinky RTIC example to work with latest BSP changes

---------

Signed-off-by: Arne Kappen <[email protected]>
Co-authored-by: Arne Kappen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants