Improve the architecture of SpiFuture
#577
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleyharden
force-pushed
the
improve_spi_future
branch
3 times, most recently
from
3e850bb to
101aa59
Compare
|
@bradleyharden, I quite like this. I think it definitely makes |
|
I still need to backport some other bug fixes. That's why I it's still a WIP |
After trying to use `SpiFuture` in the real world, I encountered some problems that these changes address. Specifically, I added the ability for the `Spi` struct to be part of some user type. The `AsSpi` trait provides an interface for the `SpiFuture`. This has the added benefit of simplifying the implementation.
- Make conversion from `Status` to `Error` an inherent function of `Status` rather than an implementation of `TryFrom` - Add a `DynCapability` enum to allow run-time branching on `Capability` - Improve type-level consistency for the `AnyConfig` and `AnySpi` traits - Change how the `.get_dyn_length()` and `.set_dyn_length()` methods are restricted to only those structs with `DynLength` - Remove calls to `assert_eq!` to help limit formatting code - Fix bugs related to `Tx` `Capability`
bradleyharden
force-pushed
the
improve_spi_future
branch
from
101aa59 to
8139d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to use
SpiFuturein the real world, I encountered someproblems that these changes address. Specifically, I added the ability
for the
Spistruct to be part of some user type. TheAsSpitraitprovides an interface for the
SpiFuture. This has the added benefit ofsimplifying the implementation.
Summary
[describe your changes here]
Checklist
CHANGELOG.mdfor the BSP or HAL updated