-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize bsp api with an eye towards clean docs #357
base: master
Are you sure you want to change the base?
Conversation
c39e6d4
to
0da09cf
Compare
Sorry for the inconsistent style with the wio_terminal - it wasnt my intention to buck the trend, but I do think consistency is ideal. I can also tackle updating some of the other BSPs if that would help? I have hardware for the itsybitsy's. |
Just regarding the |
fa5f950
to
772f5e2
Compare
75db9f0
to
3e8f060
Compare
@jacobrosenthal @jbeaurivage Should we close this now that pygamer has been cleaned up? |
I think there is still a little bit of work to do in |
Just to start a discussion around what our bsp api should look like.
Most of us are using inherited a pattern that splashes the hal into the main export that ends up looking like this
https://docs.rs/pygamer/0.6.0/pygamer/
Recently merged bsps clearly rethought that. Take a look at
https://docs.rs/wio_terminal/0.2.0/wio_terminal/
I presume wed like to be harmonized. And presumably wed all like our docs to look nice.
These were the (breaking) changes I made to the pygamer and edgebadge just to generally clean them up, and ended up converging to the wio terminal style.
Though Id prefer to match whatever we all decide.