Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NONE: Figma OAuth updates #249

Merged
merged 2 commits into from
Jan 17, 2025
Merged

NONE: Figma OAuth updates #249

merged 2 commits into from
Jan 17, 2025

Conversation

ehasama-figma
Copy link
Collaborator

Figma is encouraging our REST API clients to use the Basic auth header to transmit OAuth credentials and use token exchange endpoints defined on api.figma.com. So this PR makes these updates.

Test Plan

  • updated integration tests such that they pass
  • unit tests pass
  • manually tested authenticating locally

Copy link

Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution.
If your email is listed below, please ensure that you sign the CLA with the same email address.

The following users still need to sign our CLA:
❌ehasama-figma

Already signed the CLA? To re-check, try refreshing the page.

Copy link
Collaborator

@Roystbeef Roystbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@decompil3d decompil3d merged commit 88261c2 into main Jan 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants