NONE: fix processing large file jsons from get file #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into
Cannot create a string longer than 0x1fffffe8 characters
errors that we were able to pinpoint to theresponse.data
call when calling get file.This is because the JSON string that gets returned from Figma can be over 512 MB in length. So instead of treating it as a single string, this PR updates that logic so we stream in and build up the JSON object for the file.
Test Plan